Dialogue uses standard tracing tags #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately dialogue doesn't make it easy to discover the endpoint path template, we may wish to expose it in the future.
Generate changelog in
|
jkozlowski
reviewed
Apr 21, 2021
| @@ -57,7 +59,7 @@ | |||
| sink.tag(target, tags); | |||
| int status = response.code(); | |||
| sink.tag(target, "outcome", status / 100 == 2 ? "success" : "failure"); | |||
| sink.tag(target, "status", Integer.toString(status)); | |||
| sink.tag(target, TraceTags.HTTP_STATUS_CODE, Integer.toString(status)); | |||
There was a problem hiding this comment.
You could probably also centralize the int -> String for status codes? I think you have that multi-if-statement in abunch of places.
jkozlowski
approved these changes
Apr 21, 2021
|
Released 1.118.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately dialogue doesn't make it easy to discover the
endpoint path template, we may wish to expose it in the future.
==COMMIT_MSG==
Dialogue uses standard tracing tags
==COMMIT_MSG==